Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement VM pause and resume #15

Merged
merged 2 commits into from
Oct 4, 2023
Merged

feat: implement VM pause and resume #15

merged 2 commits into from
Oct 4, 2023

Conversation

00xc
Copy link
Contributor

@00xc 00xc commented Oct 4, 2023 •
edited
Loading

📑 Description

Implement VM pause and resume, which is needed to take snapshots, as detailed here.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code is documented
  • I provided unitary tests or procedure to test my code
  • My PR have a clear description of what my code is supposed to do

@00xc 00xc requested a review from alexandrebrg as a code owner October 4, 2023 08:51
00xc added 2 commits October 4, 2023 10:52
@00xc
refactor(executor): take HTTP method in Executor::send_request()
9ac0f2c 
Allow callers to set the HTTP method instead of hardcoding it to PUT.

Signed-off-by: Carlos López <[email protected]>
@00xc
feat: implement VM pause and resume
8f8c770 
Signed-off-by: Carlos López <[email protected]>
alexandrebrg
alexandrebrg approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@alexandrebrg alexandrebrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @00xc, thank you for your contribution. A simple & quick new feature, LGTM

@alexandrebrg alexandrebrg merged commit 7d3621c into rik-org:main Oct 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebrg alexandrebrg alexandrebrg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@00xc @alexandrebrg